2046 - Mulitproduct AAQ CTA URL #6536
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR addresses Issue 2046 by modifying the AAQ CTA behavior when multiple products are available. The changes update the AAQ context setup to include a new parameter that determines if multiple products exist, and update the related utility function accordingly.
- Update in kitsune/wiki/views.py to pass a multiple_products flag based on the number of products.
- Update in kitsune/sumo/utils.py to adjust the set_aaq_context signature and include the multiple_products information.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| kitsune/wiki/views.py | Modified call to set_aaq_context to conditionally pass multiple_products |
| kitsune/sumo/utils.py | Updated function signature and session context to include multiple_products |
Comments suppressed due to low confidence (2)
kitsune/wiki/views.py:241
- [nitpick] Consider simplifying the boolean expression for multiple_products by using 'len(products) > 1' directly for improved clarity.
set_aaq_context(request, product, multiple_products=True if len(products) > 1 else False)
kitsune/sumo/utils.py:399
- [nitpick] Update the docstring to document the new 'multiple_products' parameter for clarity and consistency.
def set_aaq_context(request, product, multiple_products=False):
escattone
reviewed
Mar 11, 2025
kitsune/wiki/views.py
Outdated
| @@ -238,7 +238,7 @@ def maybe_vary_on_accept_language(response): | |||
| product = products.first() | |||
|
|
|||
| # Set the AAQ context for the widget | |||
| set_aaq_context(request, product) | |||
| set_aaq_context(request, product, multiple_products=True if len(products) > 1 else False) | |||
There was a problem hiding this comment.
This can just be multiple_products=len(products) > 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses mozilla/sumo#2046
The AAQ CTA in the sidebar would send the user to the new question page for the first product on documents where there were multiple products.
Now we set
multiple_productsin theaaq_contextand if there are multiple products we will send the user to/questions/newso they can select a product.